WIP: absorb format boundaries into RichText toTree #11322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Status] In Progress
4 tasks
ellatrix
force-pushed
the
try/format-boundaries
branch
from
5ab1d62
to
fbeb0e3
Compare
|
It's still in progress, I'm removing it from 4.5 milestone. |
This was referenced Jan 3, 2019
ellatrix
force-pushed
the
try/format-boundaries
branch
2 times, most recently
from
e064508
to
718b4fe
Compare
ellatrix
force-pushed
the
try/format-boundaries
branch
from
851cfb4
to
e269593
Compare
ellatrix
force-pushed
the
try/format-boundaries
branch
from
7463176
to
86de3a9
Compare
ellatrix
force-pushed
the
try/format-boundaries
branch
from
30aba75
to
421876c
Compare
ellatrix
requested review from
aduth,
ajitbohra,
gziolo,
jorgefilipecosta,
nerrad,
oandregal,
ntwb,
Soean and
youknowriad
as code owners
|
First impressions: It seems to work fairly well. Bug encountered for now: "Backspacing at the beginning of a paragraph with a format applied" don't merge blocks. |
|
Another small bug but I believe this one is also an existing bug in master:
|
|
Closing in favour of #13697. |
|
@youknowriad That last issue you're describing is currently an issue as well I think. See #11743. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related: #13153, #12973, #12978, #11091, #12966, #11178, #11276, #11743.
This PR adds boundary logic to the Rich Text package.
How is it done? Zero width non breaking spaces are being added in front of the text inside the format element, and in front of the text after the format element. These are used the trick the browser to move the caret next to them. This basic addition already fully enables inserting text in any position. Of course the zero width characters are only added to the editable tree, not the saved one.
Next, we look at the deepest selected format, which receives a class to style the selected element. To know the selected format, the state must have some additional information about which format is selected at a certain index. We need add an extra property to the value
selectedFormat:0for outside,1for inside the first format,2for inside the second format, if any, etc. This information is derived from the DOM duringcreate.To do:
getActiveFormatunit tests.How has this been tested?
Screenshots
Types of changes
Checklist: